-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start switching to Github Actions for CI #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
We can deal with double build problem later on.
@@ -0,0 +1,35 @@ | |||
name: RSpec CI | |||
on: [pull_request, push] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this needs to be tweaked so we only run push
on main
/*-maintenance
/*-dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like? I am not sur for pull_request.
on:
# Trigger the workflow on push or pull request,
# but only for the main branch
push:
branches:
- main
- *-maintenance
- *-dev
pull_request:
branches:
- **
- 2.1.9 | ||
- ruby-head | ||
fail-fast: false | ||
continue-on-error: ${{ matrix.ruby == 'jruby-9.2.13.0' || endsWith(matrix.ruby, 'head') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
head at least is needed post 3.0.0's release, and the jruby one is needed until its fixed
@JonRowe @benoittgt We have this left:
Are we moving those to GHA? I've missed your |
@pirj yes when I figure it out 😂 |
Windows is coming in hot though 🔥 |
🕺 |
No description provided.